Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close serial port when exception #311

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: close serial port when exception #311

merged 1 commit into from
Oct 9, 2024

Conversation

horw
Copy link
Member

@horw horw commented Oct 9, 2024

Description

Fixing issue with not closed serial

Related

Closes #307

Testing

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@horw horw requested a review from hfudev October 9, 2024 08:19
@horw horw force-pushed the fix/close_port_when_exception branch from 702d821 to fe71a78 Compare October 9, 2024 11:13
@hfudev hfudev merged commit c2e2d0f into espressif:main Oct 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfudev hfudev hfudev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serial File Descriptor Not Closed When Error Occurs in Serial.__init__ (RDT-912)
2 participants
@horw @hfudev